| T O P I C R E V I E W |
| alexG |
Posted - Feb 26 2014 : 02:47:15 AM
Hello,
according to the release notes:
New! Change Signature prompts for value to insert when adding parameter placeholder to call references. (case=58410) 10220
That would be very cool, but how does this work ?
I don't get a prompt to enter the default value for a new parameter ...
int Test( int numberFirst, int test2 )
{
return numberFirst + 1;
}
void UseTest()
{
Test( 0 );
}
Shouldn't the call UseTest get the new parameter test2 ?
Regards,
Alex
Visual Studio 2013, Window 8.1 |
| 14 L A T E S T R E P L I E S (Newest First) |
| sean |
Posted - Apr 07 2014 : 3:31:57 PM
case=80605 was opened for the problem reported by alexG.
case=80605 is fixed in build 2031 |
| sean |
Posted - Feb 28 2014 : 7:40:19 PM
Taken up in case=80582. |
| alexG |
Posted - Feb 28 2014 : 04:38:14 AM
Ok. I have sent the logs.
( I couldn't find an errors.log ) |
| sean |
Posted - Feb 27 2014 : 12:29:48 PM
Let's try logging to see if anything shows up:
http://support.wholetomato.com/default.asp?W305
Submit to http://www.wholetomato.com/support/contact.asp |
| alexG |
Posted - Feb 27 2014 : 12:24:43 PM
Sorry, no improvement.
- I have tested it in a complete different solution / project ( Windows 8.1, VS 2013 )
- I have tested it in a virtual machine ( Windows 7, VS 2005 )
Could it be related to the system language / region settings ?
A installed extension in VS ?
Besides Visual Assist there are a Perforce P4VS and an Xoreax Incredibuild.
|
| sean |
Posted - Feb 27 2014 : 12:04:12 PM
I notice that your test is at the bottom of a file (or at least well into it at line 2096). Can you please try it at the top of the file just to see if that makes a difference (maybe something in the file is causing an issue)? |
| alexG |
Posted - Feb 27 2014 : 02:10:33 AM
Yes. Even after I have changed the signature. |
| sean |
Posted - Feb 26 2014 : 3:29:10 PM
Does rename of the Run method replace both occurrences? |
| alexG |
Posted - Feb 26 2014 : 3:05:10 PM
This is what I get :
Output from 'Find references':
gc2adtemplates.cpp(2096, 9): void Run( int bla, int bla2 )
gc2adtemplates.cpp(2104, 8): test.Run( 1 );
|
| sean |
Posted - Feb 26 2014 : 2:59:21 PM
Strange. When you run Change Signature, does the list in the dialog show both the definition and the reference?
Run Find References on Test::Run. Does it show 2 hits? |
| alexG |
Posted - Feb 26 2014 : 2:50:26 PM
Hi,
here are the infos:
VA_X.dll file version 10.8.2029.0 built 2014.02.24
DevEnv.exe version 12.0.30110.0 Professional
msenv.dll version 12.0.30110.0
Comctl32.dll version 6.10.9600.16384
Windows 8.1 6.3 Build 9600
12 processors (x86-64, WOW64)
Language info: 1252, 0x407
|
| sean |
Posted - Feb 26 2014 : 12:05:06 PM
Your example is working for me. Can you please confirm that 2029 successfully installed by checking the version info at VAssistX | Help | About? |
| alexG |
Posted - Feb 26 2014 : 11:15:23 AM
Hi,
After executing the Change Signature from the context menu again, I still don't get any changes on the call sites.
E.g. I added 'bla2' to the signature using the Change Signature dialog.
The caller wasn't changed.
class Test
{
public:
Test(){};
void Run( int bla, int bla2 )
{};
};
void TestTest()
{
Test test;
test.Run( 1 );
}
|
| sean |
Posted - Feb 26 2014 : 11:04:46 AM
Build 2029 adds on to the Change Signature command. When using the VA Change Signature command, if you add a new parameter, then VA will update call sites. Prior to 2029, VA would simply add TODO to the call sites. Now it prompts you for the text to insert.
I think you are expecting an automatic invocation of Change Signature upon edit of a declaration or implementation. That is feature request case=70849. Until then, to get the new prompt in build 2029, you have to manually invoke Change Signature.
Let us know if I didn't understand your post.
|
