Whole Tomato Software Forums
Whole Tomato Software Forums
Main Site | Profile | Register | Active Topics | Members | Search | FAQ
User name:
Password:
Save Password
Forgot your password?

 All Forums
 Visual Assist
 Technical Support
 what does VAssist do with Ctrl-Y
 New Topic  Reply to Topic
 Printer Friendly
Author Previous Topic Topic Next Topic  

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 15 2019 :  5:10:50 PM  Show Profile  Reply with Quote
Hi
I'm using vsvim and have an issue with Ctrl-Y when Visual Assist is enabled. If I disable Visual Assist Ctrl-Y works as expected - in insert mode it copies characters from the line above. Ctrl-E always works (copies from below) but when Visual Assist is enabled Ctrl-Y does nothing.

I have nothing mapped to Ctrl-Y in tools->customize->keyboard nor in the Visual Assist keyboard mapping dialog.

Cheers
Rob

Visual Assist version is quite old ...

License: xxxxxxxxxx (6-user license) Support ends 2018.05.15
VA_X.dll file version 10.9.2270.0 built 2018.04.30
DevEnv.exe version 15.9.28307.586 Community
msenv.dll version 15.0.28307.421
Comctl32.dll version 6.10.18362.10012
Windows 10 10.0 Build 18362.10012
8 processors (x86-64, WOW64)
Language info: 1252, 0x409

Platform: Project defined
Stable Includes:

Other Includes:

Stable Source Directories:

accord
Whole Tomato Software

United Kingdom
3277 Posts

Posted - Sep 16 2019 :  03:55:15 AM  Show Profile  Reply with Quote
I was able to reproduce the problem using VSVim + VAssistX + VS2019. I see you're using VS2017.

I have put in a bug report for this:

case=141246
Go to Top of Page

accord
Whole Tomato Software

United Kingdom
3277 Posts

Posted - Sep 16 2019 :  03:57:27 AM  Show Profile  Reply with Quote
Is this the only shortcut where you're experiencing compatibility problem with Visual Assist?
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 16 2019 :  6:02:55 PM  Show Profile  Reply with Quote
quote:
Originally posted by accord

Is this the only shortcut where you're experiencing compatibility problem with Visual Assist?



As far as I'm aware yes

thanks
Rob
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 09 2020 :  11:26:51 AM  Show Profile  Reply with Quote
Nearly a year's gone by ...

is there any chance this will be looked at?

fwiw Ctrl+E works fine (does the same thing but from the line below)

cheers
Rob
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 10 2020 :  06:39:46 AM  Show Profile  Reply with Quote
We have looked at this, but its not quite clear where the problem is coming from. Both VA and VSVim are updating the IDE, so need to cooperate with each other, and any other extensions that are also altering how the IDE might work.

One of our developers did submit a code change to VSVim to try and fix the problem, but this was around the same time as the last release of VSVim. Have you tried building VSVim from source code, to see if this makes any difference? I am wondering if the changes made it into the current release of VSVim.

zen is the art of being at one with the two'ness
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 10 2020 :  06:43:37 AM  Show Profile  Reply with Quote
Ok I'll try building from the latest sources

thanks
Rob
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 10 2020 :  4:30:44 PM  Show Profile  Reply with Quote
Latest vsvim built from source still has the problem.

ctrl-E works, ctrl-Y doesn't - cursor doesn't even move

cheers
Rob
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 14 2020 :  07:28:29 AM  Show Profile  Reply with Quote
Looking at the notes our developers made, this is one of the changes that they submitted to VSVim, are you able to add some logging to your compiled version of VSVim to make sure that the registry key check is correctly picking up the fact that VA has been installed?

https://github.com/VsVim/VsVim/commit/c8e10f51108d89d4f9e596a6f5203bbdfe6a7ffa#diff-1ebfcb8f32a4c8f7c942b922299128b9

zen is the art of being at one with the two'ness
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 14 2020 :  07:51:38 AM  Show Profile  Reply with Quote
Hi

yeah I can do that

Rob
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 15 2020 :  6:10:32 PM  Show Profile  Reply with Quote
Ok it is detecting VS2019, and returning VANet16 from GetRegistryKeyName(VisualStudioVersion version)

Rob
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 16 2020 :  09:58:44 AM  Show Profile  Reply with Quote
Thank you for checking this. I have updated our bug report with this information.

For now, if you want to try and figure out what is going on in ViVim, it seems that the VA compatibility code is found here:

https://github.com/VsVim/VsVim/tree/master/Src/VsVimShared/Implementation/VisualAssist

and our developers have wondered if full VA compatibility was removed at some point.

As an alternative, have you considered trying ViEmu

http://www.viemu.com

I have just checked, and Ctrl-Y is working correctly in insert mode with ViEmu in VS2019 and VA 2389.

zen is the art of being at one with the two'ness
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 16 2020 :  10:14:10 AM  Show Profile  Reply with Quote
heh yeah I do/did actually have a license for viemu but found that vsvim played a bit better with vax, + development on it seemd to have stopped.

I _can_ make do without ctrl-Y - it's not like that's the only thing I miss in vsvim compared to real vim


cheers
Rob
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 17 2020 :  03:05:56 AM  Show Profile  Reply with Quote
I suppose this is obvious but ctrl-y _does_ work when I'm not editing a source file (eg a .txt file)
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 17 2020 :  06:29:21 AM  Show Profile  Reply with Quote
I found the same thing in my testing. But remember, both VA and viemu are trying to "change" how the IDE works, and on occasion moving the caret around due to inserting text that you have not directly typed into the editor. Plenty of room for conflicts, sad to say.

zen is the art of being at one with the two'ness
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 17 2020 :  06:34:24 AM  Show Profile  Reply with Quote

yeah - it's just I get the impression that somehow vsvim never even sees the ctrl-y

I changed the impl of ctrl-y in the vsvim code to do what ctrl-E does, and that also didn't work. A somewhat blunt-edged test I know (my f-sharp/vsix debugging skills are 0) but to me that looks like va is intercepting ctrl-y and never passing it on

ps I assume you mean vsvim (not viemu)

cheers
Rob

Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 17 2020 :  07:01:00 AM  Show Profile  Reply with Quote
Yes, vsvim, but the same point applies to viemu as well

In your IDE settings:

IDE tools menu -> Options -> Environment -> Keyboard

have you looked to see if Ctrl-Y is mapped to anything? It is possible it is not reaching vsvim since the IDE is capturing it. On my system Ctrl-Y is mapped to "Edit.Redo" with global scope. Removing this key mapping might change what happens for you.

zen is the art of being at one with the two'ness
Go to Top of Page

bins
Ketchup Master

United Kingdom
67 Posts

Posted - Sep 17 2020 :  07:23:54 AM  Show Profile  Reply with Quote
It's not mapped - worth double checking though
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
16896 Posts

Posted - Sep 17 2020 :  1:48:27 PM  Show Profile  Reply with Quote
I would not expect VA to capture Ctrl-Y unless it was mapped in the IDE keyboard shortcuts settings. Have you tried to work out where keyboard shortcuts are captured inside the extension?

I don't see why VA being active should stop the keyboard shortcut from registering, but I haven't looked at any of the code myself.

zen is the art of being at one with the two'ness
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Reply to Topic
 Printer Friendly
Jump To:
© 2019 Whole Tomato Software, LLC Go To Top Of Page
Snitz Forums 2000