Whole Tomato Software Forums
Whole Tomato Software Forums
Main Site | Profile | Register | Active Topics | Members | Search | FAQ
User name:
Password:
Save Password
Forgot your password?

 All Forums
 Visual Assist
 Technical Support
 VAX 1616: Change Signature renames comments
 New Topic  Reply to Topic
 Printer Friendly
Author Previous Topic Topic Next Topic  

accord
Whole Tomato Software

United Kingdom
3287 Posts

Posted - Nov 14 2007 :  09:43:40 AM  Show Profile  Reply with Quote
C++, VS 2005 SP1

I used change signature to change the name of a function parameter (in a cpp file). I had a similar string in a comment, in my previous function body, and VAX renamed it also.

It is very important to disable find references' find comments and strings feature when change signature invokes rename (which invokes the find references)

I hope it will be very high priority bug

feline
Whole Tomato Software

United Kingdom
19022 Posts

Posted - Nov 14 2007 :  1:50:18 PM  Show Profile  Reply with Quote
There is certainly a problem here, I am just not sure of the best solution. Renaming the correct comments is good if your function is commented.

case=9930

zen is the art of being at one with the two'ness
Go to Top of Page

accord
Whole Tomato Software

United Kingdom
3287 Posts

Posted - Nov 14 2007 :  3:53:36 PM  Show Profile  Reply with Quote
quote:
I am just not sure of the best solution.


Rename should only search inside affected function's body and comments prior to function header.

But one thing is a little problematic: while rename populate a listbox with found comments, change signature's rename feature is working automatically. Automatically renaming comments is not a safe thing

Change signature should allways pop up the rename dialog before renaming, or when there are comments in the result at least. This idea is absolutely great in rename dialog!

Ps.: Maybe turning off "comments rename" in change signature as a hotfix?

Edited by - accord on Nov 14 2007 3:54:58 PM
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
19022 Posts

Posted - Nov 15 2007 :  08:41:05 AM  Show Profile  Reply with Quote
We are looking for a quick fix for these reasons and leaning towards the rename dialog appearing longer term.

Defining the "attached" comment can get interesting though, I thought up some interesting test cases when testing rename and comments. Overloaded functions was a good way to produce interesting effects.

zen is the art of being at one with the two'ness
Go to Top of Page

sean
Whole Tomato Software

USA
2817 Posts

Posted - Nov 15 2007 :  9:35:44 PM  Show Profile  Reply with Quote
case=9930 is fixed in build 1618 (restored to old behavior)
Go to Top of Page

hotzenplotz
Senior Member

Austria
34 Posts

Posted - Nov 22 2007 :  08:49:12 AM  Show Profile  Reply with Quote
Maybe pop up the rename dialog if and only if any matches are found in comments and/or string?

Use the source, Luke!
Go to Top of Page

feline
Whole Tomato Software

United Kingdom
19022 Posts

Posted - Nov 22 2007 :  10:25:06 AM  Show Profile  Reply with Quote
That is our longer term plan.

zen is the art of being at one with the two'ness
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Reply to Topic
 Printer Friendly
Jump To:
© 2023 Whole Tomato Software, LLC Go To Top Of Page
Snitz Forums 2000