When you surround a block of code by #if 0...#endif, you should make sure there's a newline inserted after the #endif if there's not already.
A programmer on my team used that VAssistX function and didn't have the end of the selection on the start of a line, so there was code to the right of the #endif, which the compiler ignored.
ex:
old code
...
else if (foo())
bar();
else
baz();
after modification, where selection was before the "else if" and on a space to the left of the "else"
...
#if 0
else if (foo())
bar();
#endif else
baz();
Now baz() was executing unconditionally because the preprocessor skips the else. Of course, we caught this quickly, but it'd be nice to have VAssistX better understand intent.
surround by #if 0 ... #endif should have a newline
Posted - Oct 18 2012 : 08:37:04 AM
