Whole Tomato Software Forums
Whole Tomato Software Forums
Main Site | Profile | Register | Active Topics | Members | Search | FAQ
 All Forums
 Visual Assist
 Technical Support
 "Change Signature" and virtual methods

You must be registered to post a reply.
Click here to register.

Screensize:
UserName:
Password:
Format: BoldItalicizeUnderlineStrikethrough Align leftCenterAlign right Insert horizontal ruleUpload and insert imageInsert hyperlinkInsert email addressInsert codeInsert quoted textInsert listInsert Emoji
   
Message:

Forum code is on.
Html is off.

 
Check to subscribe to this topic.
   

T O P I C    R E V I E W
MrDoomMaster Posted - Nov 27 2007 : 1:18:00 PM
VAX Build: 1519
IDE: Visual Studio 2008 (VS9)

Hi,

Consider the following C++ code example below:


class Foo
{
public:
	virtual void MyFunc( int val ) = 0;
}

class Bar : public Foo
{
public:
	virtual void MyFunc( int val )
	{
	}
};

class FooBar : public Bar
{
	virtual void MyFunc( int val )
	{
	}
};


If I do "Change Signature" on Foo::MyFunc(), it does not apply whatever changes I make to the derived versions of the virtual method. I think it should make these changes, ESPECIALLY in the case where you have a pure virtual involved (However it should recursively modify the derived versions of the virtual signature regardless of if it is pure virtual or not).

If you do a "Find References" on Foo::MyFunc(), it gives you the derived versions in the search results. So VAX obviously is capable of finding the derived virtual overrides.

It would make sense to have "Change Signature" also apply any changes I make to BASE AND DERIVED matching virtual function signatures. Note that this does not apply to non-virtual overrides.

Scenarios:
- If I "Change Signature" on Foo::MyFunc(), both Bar::MyFunc() and FooBar::MyFunc() are modified as well.
- If I "Change Signature" on Bar::MyFunc(), both Foo::MyFunc() and FooBar::MyFunc() are modified as well.
6   L A T E S T    R E P L I E S    (Newest First)
sean Posted - Nov 18 2013 : 3:25:59 PM
Change Signature was overhauled in build 2007 and now supports changes to a class hierarchy.
MrDoomMaster Posted - Nov 30 2007 : 1:32:45 PM
quote:
Originally posted by accord

It will be a new feature, rather than improvement


Good point. I misread :)
accord Posted - Nov 30 2007 : 1:31:21 PM
quote:
Originally posted by MrDoomMaster

quote:
Originally posted by accord

It will be the most useful refactoring improvement!



I beg to differ. I personally believe comment wrapping would be the most useful, however that's a little out of the scope of this thread.



Comment wrapping will be new feature, rather than improvement
MrDoomMaster Posted - Nov 30 2007 : 1:27:07 PM
quote:
Originally posted by accord

It will be the most useful refactoring improvement!



I beg to differ. I personally believe comment wrapping would be the most useful, however that's a little out of the scope of this thread.
accord Posted - Nov 30 2007 : 1:22:56 PM
It will be the most useful refactoring improvement!
feline Posted - Nov 27 2007 : 3:15:50 PM
We are considering doing this at some point:

case=3373

© 2019 Whole Tomato Software, LLC Go To Top Of Page
Snitz Forums 2000