| T O P I C R E V I E W |
| Fukkei |
Posted - May 15 2020 : 05:38:33 AM
Hy there, I'm looking for an assistance from WholeTomato team.
On my PC I have noticed a huge performance degradation when I search via ctrl+shift+f with VA enabled. Search takes now up to a minute vs 2-5 seconds without VA.
Hot stack from xperf:
|Line # | Process | Thread Name | Thread ID | Stack | Count | Weight (in view) (ms)|
|--- | --- | --- | --- | --- | --- | ---|
|1 | devenv.exe (10696) | | | | 19550 | 19,636.151900|
|2 | | | 17548 | | 17568 | 17,643.352700|
|3 | | | | [Root] | 17432 | 17,507.047000|
|4 | | | | \|- ntdll.dll!_RtlUserThreadStart | 13257 | 13,315.425800|
|5 | | | | \| ntdll.dll!__RtlUserThreadStart | 13257 | 13,315.425800|
|6 | | | | \| kernel32.dll!BaseThreadInitThunk | 13257 | 13,315.425800|
|7 | | | | \| devenv.exe!__scrt_common_main_seh | 13257 | 13,315.425800|
|8 | | | | \| devenv.exe!WinMain | 13257 | 13,315.425800|
|9 | | | | \| devenv.exe!CDevEnvAppId::Run | 13257 | 13,315.425800|
|10 | | | | \| devenv.exe!util_CallVsMain | 13257 | 13,315.425800|
|11 | | | | \| msenv.dll!_VStudioMain | 13257 | 13,315.425800|
|12 | | | | \| msenv.dll!VStudioMainLogged | 13257 | 13,315.425800|
|13 | | | | \| msenv.dll!CMsoComponent::PushMsgLoop | 13257 | 13,315.425800|
|14 | | | | \| msenv.dll!SCM_MsoCompMgr::FPushMessageLoop | 13257 | 13,315.425800|
|15 | | | | \| msenv.dll!SCM::FPushMessageLoop | 13257 | 13,315.425800|
|16 | | | | \| msenv.dll!CMsoCMHandler::FPushMessageLoop | 13257 | 13,315.425800|
|17 | | | | \| \|- msenv.dll!CMsoCMHandler::EnvironmentMsgLoop | 12566 | 12,622.441400|
|18 | | | | \| \| \|- ?!? | 12306 | 12,361.618600|
|19 | | | | \| \| \| \|- ?!? | 12304 | 12,359.618600|
|20 | | | | \| \| \| \| \|- user32.dll!DispatchMessageW | 12302 | 12,357.618800|
|21 | | | | \| \| \| \| \| \|- ntdll.dll!KiUserCallbackDispatcher | 7007 | 7,024.501400|
|22 | | | | \| \| \| \| \| \| user32.dll!__fnDWORD | 7007 | 7,024.501400|
|23 | | | | \| \| \| \| \| \| \|- user32.dll!DispatchClientMessage | 7004 | 7,021.507600|
|24 | | | | \| \| \| \| \| \| \| user32.dll!UserCallWinProcCheckWow | 7004 | 7,021.507600|
|25 | | | | \| \| \| \| \| \| \| \|- user32.dll!_InternalCallWinProc | 6990 | 7,007.492000|
|26 | | | | \| \| \| \| \| \| \| \| \|- VA_X.dll!<Missing ImageId event> | 6330 | 6,345.897600|
If I disable VA everything goes back to normal.
I don't see an issue like this on my VS 2017 installed on the same PC.
Some details that can help the investigation: I've installed VS 2019, installed VA extension via the marketplace, and then imported all settings from VS 2017 via Import/Export settings dialog to preserve my custom hotkeys. After opening a solution that I work with I've noticed this problem.
I've tried cache/history cleanup in VA, source database rebuild, then re-install that included %appdata%\local\VisualAssist && %appdata%\roaming\VisualAssist folders removal. No luck so far.
Visual Assist build 2375 |
| 10 L A T E S T R E P L I E S (Newest First) |
| feline |
Posted - May 26 2020 : 07:00:18 AM
Thank you for the detailed update and results. This is very specific, but also a situation that others are likely to run into sooner or later. |
| Fukkei |
Posted - May 26 2020 : 04:02:07 AM
Just to make this topic complete in order to help anyone with the same problem. After spending some time on tests Me and Tomato Support were able to figure out my environment specifics that probably cause the issue:
- Enabled VA Bar
- Two vertial tab groups
- Two monitors, main 144Hz refresh rate, secondary 60Hz
- Visual Studio located on the main monitor.
Any of the following steps bring Find to normal:
- Disabling VA Bar
- Switching to a single split view
- Unplugging any of the monitors
- Lowering 144Hz refresh rate to 60Hz on the main monitor
- Moving Visual Studio to the secondary monitor
Although the cause of the problem is still unknown I found a solution for myself. Feline and Team, thanks a lot for your help! |
| feline |
Posted - May 19 2020 : 07:34:45 AM
There has to be another factor at work here, since I cannot reproduce this with these settings here. This is currently being discussed via email:
case=142278 |
| Fukkei |
Posted - May 18 2020 : 1:01:04 PM
I was able to figure out which settings item breaks my find, it's "Display VA Navigation Bar" along with two vertical tab groups. Subsettings are: display on "Top", "Alphabetical sort of methods in dropdown". Unchecking "Display VA Bar" makes everything work fine. |
| feline |
Posted - May 18 2020 : 09:54:00 AM
I can reproduce 2 to 3 times slower here:
case=142279
for me the trigger, in addition to the vertical tab group, is the setting:
VA Options -> Coloring and Attributes -> Apply coloring to -> Views = ON
does turning off colouring views fix the slow down for you? I am wondering if this is the only trigger, or if there is another trigger also at work for you. |
| feline |
Posted - May 18 2020 : 07:24:52 AM
So far I can get find in files to run at about half speed, but only on one machine. Moving a single open file into a new vertical tab group is the trigger for the slow down here, but it looks like there has to be another factor or two at work as well, to explain the full terrible speed impact you are seeing, plus to reproduce on demand.
While I experiment here to see what I can reproduce, can you please export your VA and IDE settings and send them to me:
VA Options -> Performance -> Export Settings
IDE tools menu -> Import and Export Settings -> Export selected environment settings
I can then import them here and see if I can reproduce the problem. Please send me the files via email:
[email protected]
including this thread ID or URL in the description, so we can match it up. |
| Fukkei |
Posted - May 16 2020 : 11:43:10 AM
Actually I never close tabs :) I just use alt+shift+o as long as a solution stays open. Currently I have 55 files open. But I think we're close to the root of the problem. my test results:
- no open tabs: a find request goes flawlessly.
- 2 tabs in two vertial tab groups: find is dead
- no-matter-how-many-tabs in one tab group: find is alive
- 2 tabs, two tab groups, a newly created soluction consisting of two files (h/cpp): find is dead |
| feline |
Posted - May 16 2020 : 06:48:31 AM
This all seems perfectly reasonable and standard, which is puzzling. I do find in files quite a lot myself, and have never seen such an obvious slow down.
Do you have a second VS2019 solution available to test this in? I am just wondering if somehow this could be a solution specific problem.
How many tabs do you have open when doing the find? Does closing most of the open tabs make any difference to this? |
| Fukkei |
Posted - May 16 2020 : 02:25:24 AM
> How many files do you have in your solution?
8437
> When you did the find in files, what sort of find settings did you use? Was this a simple search or a regular expression search?
non-case-sensitive, entire solution search, non-regex. changing of any of these options doesn't affect the result.
an example of a search request: https://i.imgur.com/hRPteC3.png
results: https://i.imgur.com/C8kXcRw.png
> VA Options -> Highlighting -> Highlight results of Quick Find and Find in Files
I've tried to turn it off, no difference. |
| feline |
Posted - May 15 2020 : 10:45:44 AM
How many files do you have in your solution?
If you open VA's Open File in Solution dialog (Alt-Shift-O) the title bar contains two numbers. The first number is the number of files currently listed, which changes as you filter the list. The second number is the total number of files in the list, which is normally the number of files in your solution. What is this second number?
When you did the find in files, what sort of find settings did you use? Was this a simple search or a regular expression search?
Is the find returning a LOT of matches? I am wondering if the setting:
VA Options -> Highlighting -> Highlight results of Quick Find and Find in Files
could have an effect here, if there are a lot of matches in the currently open files in the IDE. |
|
|
