Whole Tomato Software Forums
Whole Tomato Software Forums
Main Site | Profile | Register | Active Topics | Members | Search | FAQ
User name:
Password:
Save Password
Forgot your password?

 All Forums
 Visual Assist
 Feature Requests
 SmartSelectExtend and statements
 New Topic  Reply to Topic
 Printer Friendly
Author Previous Topic Topic Next Topic  

xMRi
Tomato Guru

Germany
276 Posts

Posted - Jan 19 2016 :  02:05:19 AM  Show Profile  Reply with Quote
The smart select feature is really good. But it extends a select to fast.

Just take this line:

auto* pRow = m_ctrl.GetCurSel();

Assume the cursor is on the m of m_ctrl. Currently the complete statement gets selected.

I would prefer that
1. m_ctrl is selected.
auto* pRow = m_ctrl.GetCurSel();

2. Than the right side of the statement or assignment is selected
auto* pRow = m_ctrl.GetCurSel();

3. The complete Statement is selected
auto* pRow = m_ctrl.GetCurSel();


Same here
Assume the cursor is on the m of the first m_ctrl in the if clause.
Currently it just extends to the complete if -block

if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);


1. Selection should extend to the variable.
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);

2. To the right side of the expression
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);

3. The complete expression
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);

4. The if clause (complete line), a step with just the selection from open to closed pharenthesis seems not so interesting here.
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);

5. The first if clause part
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);

6. Complete if/else construct
if (iRow>=m_ctrl.GetRowCount())
    m_ctrl.AddRow(pRow);
else
    m_ctrl.InsertRowBefore(iRow, pRow);


I would like to here from you about this idea.

Greetings and happy coding
Martin

Martin Richter [rMVP] WWJD http://blog.m-ri.de
"A well-written program is its own heaven; a poorly written
program is its own hell!" The Tao of Programming

Edited by - xMRi on Jan 19 2016 02:06:20 AM

sean
Whole Tomato Software

USA
2641 Posts

Posted - Jan 19 2016 :  3:28:02 PM  Show Profile  Reply with Quote
Yes, it would make sense for the non-block variants of the Smart Select commands to be more granular -- particularly before there is a selection and before whole lines are selected. case=90797

The feature morphed quite a bit during development -- it started out without block and non-block variants, as a result was too 'slow' to grow the selection.
Go to Top of Page

sean
Whole Tomato Software

USA
2641 Posts

Posted - Jul 18 2016 :  10:43:37 PM  Show Profile  Reply with Quote
case=90797 is implemented in build 2107.
Go to Top of Page

xMRi
Tomato Guru

Germany
276 Posts

Posted - Jul 19 2016 :  12:06:35 PM  Show Profile  Reply with Quote
Thumbs up guys!

Martin Richter [rMVP] WWJD http://blog.m-ri.de
"A well-written program is its own heaven; a poorly written
program is its own hell!" The Tao of Programming
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Reply to Topic
 Printer Friendly
Jump To:
© 2019 Whole Tomato Software, LLC Go To Top Of Page
Snitz Forums 2000